Make fields optional when deserializing for compatibility #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leoyvens Thanks! Do you mind feature-gating this and adding a feature description in the README? I'd prefer to keep the library strict by default. |
leoyvens
force-pushed
the
graph-upstream-pr
branch
4 times, most recently
from
8bb4247 to
32c087a
Compare
|
@tomusdrw Thank you for the review, I've added a feature gate. |
leoyvens
force-pushed
the
graph-upstream-pr
branch
from
32c087a to
6505d41
Compare
tomusdrw
approved these changes
Jun 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are necessary for compatibility with some EVM-compatible chains such as Celo and Fantom. I hope you're willing to take this small patch to support these chains.