Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added ability to bypass whole second rounding for silence gaps #69

Merged
merged 2 commits into from
Jan 16, 2018

Conversation

davidprozesky
Copy link

Introduced to minimise the run-time memory cost of silence for atlases with appreciable numbers of members for certain platforms and contexts where memory pressure may be high. Passing '--ignorerounding=1' will eliminate the extra silence gap introduced by rounding to the nearest second.

SargoDarya
SargoDarya previously approved these changes Jan 11, 2018
@SargoDarya SargoDarya dismissed their stale review January 11, 2018 15:49

Forgot something

Copy link
Collaborator

@SargoDarya SargoDarya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the README.md to include the newly added argument. Other than that this looks very good.

@davidprozesky
Copy link
Author

Apologies, I missed those references; changes submitted.

@davidprozesky
Copy link
Author

Apologies, not sure if I have missed something; should I submit more changes?

@SargoDarya SargoDarya merged commit 63044dc into tonistiigi:master Jan 16, 2018
@SargoDarya
Copy link
Collaborator

Nope, everything good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants