Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove log #70

Merged
merged 4 commits into from
Feb 6, 2018
Merged

Remove log #70

merged 4 commits into from
Feb 6, 2018

Conversation

GMartigny
Copy link
Contributor

Files list was log without prompt.

Files list was log without prompt.
@SargoDarya
Copy link
Collaborator

SargoDarya commented Feb 5, 2018

Hey @GMartigny,

first off, thanks for your contribution. Instead of removing it, can you maybe add a check around and log it if the log level is set to info? That would be far better than removing it only.

@GMartigny
Copy link
Contributor Author

You're right, I missed the log option. I guess, it's best to use the logger functions.

@SargoDarya
Copy link
Collaborator

Just for the record, I changed the log level on the first one to info.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants