Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

以 number 當 stock key 似乎不妥 #9

Closed
dlintw opened this issue Jan 9, 2014 · 4 comments
Closed

以 number 當 stock key 似乎不妥 #9

dlintw opened this issue Jan 9, 2014 · 4 comments
Labels
bug

Comments

@dlintw
Copy link

dlintw commented Jan 9, 2014

臺灣股票應該會有含英文字母. 建議改以文字當 key,
eg.
03236C 元牛Y1
@dlintw
Copy link
Author

dlintw commented Jan 9, 2014

另外一個例子是 s = Stock(0050) 應該會失敗.

@toomore
Copy link
Owner

toomore commented Jan 10, 2014

好，我修正一下

toomore added a commit that referenced this issue Jan 10, 2014
@toomore
Add assert for stock_no. #9
38fcb43
toomore added a commit that referenced this issue Jan 10, 2014
@toomore
Add some test for '0050'. #9
cc4e644
toomore added a commit that referenced this issue Jan 10, 2014
@toomore
Add assert into realtime. #9
eccd55d
toomore added a commit that referenced this issue Jan 10, 2014
@toomore
Add test for realtime. #9
bb36eea
@toomore
Copy link
Owner

toomore commented Jan 10, 2014

@dlintw 已修正到 v0.4.2，感謝建議！

@toomore toomore closed this as completed Jan 10, 2014
@dlintw
Copy link
Author

dlintw commented Jan 11, 2014

It works.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toomore @dlintw