[MergeTree] saddle-saddle pairs processing #1066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to the merge tree filters to process saddle-saddle pairs when the input corresponds to persistence diagrams.
Until now, only min-saddle and saddle-max pairs could be processed and used at the same time (with a parameter allowing to weight the type of pairs in the final distance).
With this PR, the user can now also choose to process min-saddle and saddle-saddle pairs at the same time, or saddle-saddle and saddle-max pairs at the same time.
Choosing one of the above two options and setting a weight to respectively 0 and 1 allows to process only saddle-saddle pairs.