New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature/vs build #947

Merged

julien-tierny merged 3 commits into topology-tool-kit:dev from martinfalk:feature/vs-build

Jun 29, 2023

Contributor

martinfalk commented Jun 28, 2023

Review our Contributor Guidelines, in particular regarding code formatting (with clang-format) and continuous integration.
Please provide a quick description of your contributions below:

Two fixes for building the dev version with Visual Studio 2022:

ULONG_LONG_MAX is not part of the C/C++ standard, see https://en.cppreference.com/w/cpp/types/climits
the nested macros in IntegralLines.cpp caused a compile error with TTK_ENABLE_MPI not being enabled

martinfalk added 3 commits

June 28, 2023 15:51


          Visual Studio fix Marching Tetrahedra

c5d0520

* ULONG_LONG_MAX is not part of the C/C++ standard


          Visual Studio macro nesting fix

611fdca


          clang-format

fe9067b

Collaborator

julien-tierny commented Jun 29, 2023

awesome, thanks a lot!

julien-tierny merged commit d59af1d into topology-tool-kit:dev

45 checks passed

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet