Support kubernetes 1.31 #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
- replace exportloopref with copyloopvar due to a deprecation - fix the lint failure of the misuse of Errorf Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
As of controller-runtime 0.19.0, it validates that controller names should be unique[1]. In controller tests, we instantiate a controller multiple times, therefore, the validation fails. To avoid it, disable it. [1]: kubernetes-sigs/controller-runtime#2902 Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
toshipp
force-pushed
the
k8s-1.31
branch
2 times, most recently
from
845bb88 to
cb248a7
Compare
As of Kubernetes 1.31, it has been deleted. All our supported versions have it enabled by default. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
This fixes the lint failure due to the deprecation of grpc.Dial. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
As of kubectl 1.31, kubectl exec requires a separator between POD and COMMAND. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Because minikube changed MINIKUBE_HOME usage[1], chown now fails. To address this, use the minikube function to set permissions. [1]: kubernetes/minikube#18648 Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
If fs.protected_regular=1, the root user can't open files owned by other users in a sticky directory. This causes issues for minikube when it's run with sudo. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
cupnes
reviewed
Oct 23, 2024
There was a problem hiding this comment.
The definition of the external-snapshotter-leaderelection role can be found here:
https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml
So, please also update the following comment:
| @@ -26,7 +26,7 @@ linters: | |||
| # The rules violated to make lint work are commented out. We will fix it eventually. | |||
| - dupl | |||
| - errcheck | |||
| - exportloopref | |||
| - copyloopvar | |||
There was a problem hiding this comment.
I couldn't find the reason for this change. Could you tell me why this change was caused? Or please add a comment line for future maintenance.
There was a problem hiding this comment.
Please see the commit message. 368fd9c
golintci-lint ouputs the deprecation message.
It referred to the external provisioner Role, it was wrong. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
cupnes
approved these changes
Oct 24, 2024
llamerada-jp
approved these changes
Oct 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #951