Fixed all deprecation warnings in Ruby 2.7 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gseddon first of all - thank for for the fix! |
gseddon
force-pushed
the
fix-all-2.7-dep-warnings
branch
from
f31a5c7 to
7258771
Compare
|
Pls, one more push and this time it'll surely work ;-) (just got forks build enabled) |
gseddon
force-pushed
the
fix-all-2.7-dep-warnings
branch
from
7258771 to
4cea529
Compare
|
Let's see how this goes! |
|
Great it worked! Merging. |
|
@mrzasa do you know when we might see a new Chewy release with this PR in? |
|
Looking forward to a new Chewy release to address 2.7 deprecation warnings! Thank you for all your hard work! ❤️ |
|
Any update on this issue please? |
|
Hi folks, we are going to release a new version where these deprecations warnings in Ruby 2.7 has been fixed. |
This was referenced Mar 8, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #700
All tests are passing