Fix nil children when using witchcraft #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabotyaga
approved these changes
Jan 29, 2021
|
Thanks, @taylor-au ! |
|
@rabotyaga No problem, thanks for the great library! |
rabotyaga
pushed a commit
that referenced
this pull request
Jan 29, 2021
dalthon
pushed a commit
that referenced
this pull request
Feb 4, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
cyucelen
pushed a commit
to cyucelen/chewy
that referenced
this pull request
Jan 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of Chewy without witchcraft enabled simply nulls out any children fields where the child is null. With witchcraft enabled, Chewy will try to traverse objects even when a child is null. Code change addresses this issue.