Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add properties to ignore grammarly #3665

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jun 28, 2023

FX-4121

Description

Grammarly is still enabled in some clients, probably due to the Grammarly version that does not take into account the already existing data-gramm="false" property. Please see more details in https://toptal-core.slack.com/archives/CERF5NHT3/p1687974164415239.

Screenshot 2023-06-28 at 20 24 29

How to test

  • Testing does not appear to make sense, as it requires multiple versions of Grammarly for testing

Additional resources:

Development checks

  • Add changeset according to guidelines (if needed)
  • Read CONTRIBUTING.md and Component API principles
  • [N/A] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • [N/A] Annotate all props in component with documentation
  • [N/A] Create examples for component
  • [N/A] Ensure that deployed demo has expected results and good examples
  • [N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • [N/A] Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 51554d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-rich-text-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk self-assigned this Jun 28, 2023
@sashuk sashuk force-pushed the fx-4121-grammarly-extension-used-with-richtexteditor-caused-crash-on-client-portal-did-you-s branch from 3d92481 to 51554d6 Compare June 28, 2023 19:38
@sashuk sashuk marked this pull request as ready for review June 28, 2023 19:38
@sashuk sashuk requested a review from a team June 28, 2023 19:38
@toptal-devbot toptal-devbot temporarily deployed to temploy June 28, 2023 19:48 Inactive
@sashuk sashuk merged commit 2e8a86f into master Jun 29, 2023
@sashuk sashuk deleted the fx-4121-grammarly-extension-used-with-richtexteditor-caused-crash-on-client-portal-did-you-s branch June 29, 2023 08:20
@toptal-build toptal-build mentioned this pull request Jun 29, 2023
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants