-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Replace header "X-Forwarded-For" to standard header "Forwarded" #254
Comments
@virgil i do not think it will be a good idea to REPLACE, but we will simply "EVALUATE BOTH". let me clarify why and how we are using the x-forwarded-for as it is used in various ways and for varios reasons:
in relation to both 1) and 2) we should evaluate the implementation of the new "Forward" header checks and eventually decide the priority order for 1) among the de facto standard and the new standard. i'm wondering if in relation to the privacy concern (point 2) we should always stript the ip removal by at least replacing always the ip address that we recognize for the user with "" in every header/upstream content; what do you think @fpietrosanti / @vecna / @hellais in relation to the globaleaks project? |
Obviously don't include the for=; it's an optional parameter. Just use the "proto" and "host" And voila. A standards as well as privacy compliant version of X-forwarded-for |
tor2web#254 Replacing `X-forwarded-for` and `X-forwarded-port` with `Forwarded`.
See: https://en.wikipedia.org/wiki/X-Forwarded-For#.22Forwarded.22_Header
The text was updated successfully, but these errors were encountered: