Skip to content

Fix pattern matching for templates using dashes #230

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix pattern matching for templates using dashes #230

merged 2 commits into from
Oct 25, 2023

Conversation

zerolab
Copy link
Member

@zerolab zerolab commented Sep 25, 2023 •
edited
Loading

Fixe #229

\w./-\\ is interpreted as word, or . or range from / to \

@zerolab zerolab force-pushed the chore/resolve-template-with-dash branch from 2320f40 to f786ef7 Compare September 25, 2023 13:13
@zerolab zerolab force-pushed the chore/resolve-template-with-dash branch from f786ef7 to 4eeba6f Compare September 25, 2023 13:47
tbrlpld
tbrlpld reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test due to #233, but the changes look good.

I left one question around also doing a running a request to the render url.

@bcdickinson bcdickinson merged commit a294ccd into torchbox:main Oct 25, 2023
@zerolab zerolab deleted the chore/resolve-template-with-dash branch October 25, 2023 09:55
@zerolab zerolab mentioned this pull request Oct 25, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tbrlpld tbrlpld tbrlpld left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zerolab @tbrlpld @bcdickinson