Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support site_root_url placeholder in "default" preview client url #20

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Support site_root_url placeholder in "default" preview client url #20

merged 1 commit into from
Jan 28, 2022

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Feb 8, 2021

Fixes #16

I got stuck on updating the docs. Hope it's clear enough/acceptable

@jaap3
Copy link
Contributor Author

jaap3 commented Feb 8, 2021

The heck? The linting issue is on a line I didn't touch at all

Base automatically changed from master to main March 3, 2021 17:23
@jaap3
Copy link
Contributor Author

jaap3 commented Sep 22, 2021

@zerolab are you interested in this?

@zerolab
Copy link
Member

zerolab commented Sep 22, 2021

@jaap3 yes. it slipped under my radar. Will try to review this in the coming days!

@jaap3
Copy link
Contributor Author

jaap3 commented Jan 18, 2022

🔔 hope you get some time to review this before the one year anniversary ;-)

@zerolab
Copy link
Member

zerolab commented Jan 18, 2022

@jaap3 adding to the list of things to check next week. Will give this package some much needed love and attention

@zerolab zerolab merged commit d184f7d into torchbox:main Jan 28, 2022
@zerolab
Copy link
Member

zerolab commented Jan 28, 2022

Hey @jaap3 merged in d184f7d and parents

I made a tweak in 91e8af4 that changed the placeholder to {SITE_ROOT_URL}

Will look at making a new release this afternoon

@jaap3
Copy link
Contributor Author

jaap3 commented Jan 31, 2022

Thank you!

@jaap3 jaap3 deleted the preview-url-placeholder branch January 31, 2022 08:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEADLESS_PREVIEW_CLIENT_URLS requires hardcoded hostnames
2 participants