Skip to content

Overhaul core Tracker: add tests for authentication mod #1231

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Tracked by #1226
josecelano opened this issue Feb 3, 2025 · 0 comments · Fixed by #1232
Closed
Tracked by #1226

Overhaul core Tracker: add tests for authentication mod #1231

josecelano opened this issue Feb 3, 2025 · 0 comments · Fixed by #1232
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Quality & Assurance Relates to QA, Testing, and CI Testing Checking Torrust

Comments

@josecelano
Copy link
Member

Parent issue: #1226
@josecelano josecelano added - Developer - Torrust Improvement Experience Quality & Assurance Relates to QA, Testing, and CI Testing Checking Torrust labels Feb 3, 2025
@josecelano josecelano self-assigned this Feb 3, 2025
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
test: [torrust#1231] add tests for InMemoryKeyRepository
9576bb0
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
test: [torrust#1231] add tests for InMemoryKeyRepository
dc4e44d
@josecelano josecelano linked a pull request Feb 3, 2025 that will close this issue
Overhaul core Tracker: add tests for authentication mod #1232
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
test: [torrust#1231] add tests for InMemoryKeyRepository
8efda62
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
refactor: [torrust#1231] simplify tests for DatabaseKeyRepository
e519e7f 
We don't need the whole tracker config.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
refactor: [torrust#1231] improve DatabaseKeyRepository tests
8709540
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
refactor: [torrust#1231] exctract mod
0336ca7
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
test: [torrust#1231] add more tests to peer_key mod
5d91a32
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
refactor: [torrust#1231] peer_key mod tests
d0c7313
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
refactor: [torrust#1231] bittorrent_tracker_core::authentication::key…
0d7e30e 
…::tests
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 3, 2025
@josecelano
test: [torrust#1231] add tests for KeysHandler
e3ba1e1
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
refactor: [torrust#1231] tests to use database mock in KeysHandler
218dc14 
tests that require the `Database` trait.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
refactor: [torrust#1231] tests to use database mock in KeysHandler
abd7bca 
tests that require the `Database` trait.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
refactor: [torrust#1231] tests to use database mock in KeysHandler
b40de68 
tests that require the `Database` trait.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
refactor: [torrust#1231] tests to use database mock in KeysHandler
bd4cef6 
tests that require the `Database` trait.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
test: [torrust#1231] add more tests for KeysHandler
c3117cf
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
refactor: [torrust#1231] remove dead code
63e773a
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
test: [torrust#1231] add tests for AuthenticationService
1e6b8bf
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
test: [torrust#1231] add tests for AuthenticationService
7d8b394
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
test: [torrust#1231] add more tests for authentication::service mod
3e02b48
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Feb 4, 2025
@josecelano
fix: [torrust#1231] lint errors
3d89c7f
@josecelano josecelano mentioned this issue Feb 4, 2025
Closed
7 tasks
josecelano added a commit that referenced this issue Feb 4, 2025
@josecelano
Merge #1232: Overhaul core Tracker: add tests for authentication mod
4a9c083 
3d89c7f fix: [#1231] lint errors (Jose Celano)
3e02b48 test: [#1231] add more tests for authentication::service mod (Jose Celano)
7d8b394 test: [#1231] add tests for AuthenticationService (Jose Celano)
63e773a refactor: [#1231] remove dead code (Jose Celano)
c3117cf test: [#1231] add more tests for KeysHandler (Jose Celano)
bd4cef6 refactor: [#1231] tests to use database mock in KeysHandler (Jose Celano)
e3ba1e1 test: [#1231] add tests for KeysHandler (Jose Celano)
5db73be refactor: rename methods (Jose Celano)
0d7e30e refactor: [#1231] bittorrent_tracker_core::authentication::key::tests (Jose Celano)
d0c7313 refactor: [#1231] peer_key mod tests (Jose Celano)
5d91a32 test: [#1231] add more tests to peer_key mod (Jose Celano)
0336ca7 refactor: [#1231] exctract mod (Jose Celano)
8709540 refactor: [#1231] improve DatabaseKeyRepository tests (Jose Celano)
e519e7f refactor: [#1231] simplify tests for DatabaseKeyRepository (Jose Celano)
f485a52 refactor: inject only core config in tracker core DB setup (Jose Celano)
7c8d294 test: add tests for DatabaseKeyRepository (Jose Celano)
04ee425 chore: add todo (Jose Celano)
8efda62 test: [#1231] add tests for InMemoryKeyRepository (Jose Celano)

Pull request description:

  Overhaul core Tracker: add tests for `authentication` mod.

  Coverage before:

  ```output
  Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  packages/tracker-core/src/authentication/handler.rs                              85                17    80.00%          28                 1    96.43%         203                35    82.76%           0                 0         -
  packages/tracker-core/src/authentication/key/mod.rs                              55                 7    87.27%          18                 3    83.33%         124                12    90.32%           0                 0         -
  packages/tracker-core/src/authentication/key/repository/in_memory.rs             23                 5    78.26%          10                 2    80.00%          25                 5    80.00%           0                 0         -
  packages/tracker-core/src/authentication/key/repository/persisted.rs             15                 3    80.00%           4                 0   100.00%          17                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         201                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/service.rs                              22                 2    90.91%
  ```

  Coverage after:

  ```output
  Filename                                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  packages/tracker-core/src/authentication/handler.rs                             158                 9    94.30%          52                 0   100.00%         583                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/key/mod.rs                              35                 3    91.43%          11                 0   100.00%          96                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/key/peer_key.rs                         39                 0   100.00%          17                 0   100.00%         102                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/key/repository/in_memory.rs             51                 0   100.00%          20                 0   100.00%         169                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/key/repository/persisted.rs             24                 2    91.67%           8                 0   100.00%          77                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/mod.rs                                  67                 0   100.00%          19                 0   100.00%         219                 0   100.00%           0                 0         -
  packages/tracker-core/src/authentication/service.rs                              52                 0   100.00%          20                 0   100.00%         268                 0   100.00%           0                 0         -
  ```

ACKs for top commit:
  josecelano:
    ACK 3d89c7f

Tree-SHA512: 6107da6ab65266f4efa50b93d6c3ed38d5c5289d4d4a449b15a8aa3021d0219bfb1dc78e833675a81a2803091fa7f65db354bd6a67f5bcfcbefb55995e6d94a7
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Quality & Assurance Relates to QA, Testing, and CI Testing Checking Torrust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul core Tracker: add tests for authentication mod josecelano/torrust-tracker
1 participant
@josecelano