Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

resolve(#1104): Improve error message in announce response #1105

Closed
wants to merge 1 commit into from
Closed

resolve(#1104): Improve error message in announce response #1105

wants to merge 1 commit into from

Conversation

Binlogo
Copy link
Contributor

@Binlogo Binlogo commented Nov 24, 2024

This PR try to resolve #1104:

  • Updated error messages in test cases to include "Bad request" for better clarity when query parameters cannot be parsed.
  • Modified the From implementations for ParseQueryError and ParseAnnounceQueryError to include "Bad request" in the error messages.

@josecelano
Copy link
Member

Hi @Binlogo, thank you for the PR! I will merge it soon. Sorry for the delay I had overlooked this PR.

@josecelano
Copy link
Member

I have rebased here.

@josecelano josecelano closed this Dec 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message in announce response
2 participants
@Binlogo @josecelano