Don't execute slow doc tests #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes 32 seconds to compile and run all doc tests inckuding the ones that use the main tracker lib (each test compiles the main lib). This change disabled the compilation and execution of those tests. In terms of code coverage is not a problem becuase we have units test for that functionality. It only affects to the documentation. However there are too slow and they are even making crah some developers' computers. The good solution would be to extract those parts into new workspace packages to avoid compiling the main library. A new issue has been opened for it: torrust#1140
josecelano
force-pushed
the
1097-some-docs-tests-are-very-slow
branch
from
0bbe83b to
0e13ff7
Compare
|
ACK 0e13ff7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 76.21% 76.23% +0.02%
===========================================
Files 173 173
Lines 11543 11543
Branches 11543 11543
===========================================
+ Hits 8797 8800 +3
+ Misses 2584 2576 -8
- Partials 162 167 +5 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables slow doc tests. They are slow because they include the main library, and each test has to compile it.
They will be enabled again after moving the code to workspace sub-packages that do not depend on the main tracker lib.