-
Notifications
You must be signed in to change notification settings - Fork 49
Overhaul core Tracker: add tests for databases
mod
#1255
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
josecelano
merged 10 commits into
torrust:develop
from
josecelano:1251-overhaul-core-tracker-add-tests-for-databases-mod
Feb 11, 2025
Merged
Overhaul core Tracker: add tests for databases
mod
#1255
josecelano
merged 10 commits into
torrust:develop
from
josecelano:1251-overhaul-core-tracker-add-tests-for-databases-mod
Feb 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
896bc05
to
78b11c8
Compare
78b11c8
to
25eea20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1255 +/- ##
===========================================
+ Coverage 80.96% 81.04% +0.07%
===========================================
Files 206 206
Lines 14478 14748 +270
Branches 14478 14748 +270
===========================================
+ Hits 11722 11952 +230
- Misses 2581 2599 +18
- Partials 175 197 +22 ☔ View full report in Codecov by Sentry. |
25eea20
to
568d6d3
Compare
I've found some bugs while writing tests. I will fix them in this PR because I'm almost done and It will be merge soon. |
d83c32d
to
f233ec3
Compare
f233ec3
to
46949a6
Compare
In the tracker-core package.
…onds The `Duration` of a peer Key can have gractions of seconds. However we only store seconds (integer) in the database. When comparing peer keys we should ignore the fractions.
4d83116
to
b9188c7
Compare
ACK 2cd1c65 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
- Developer -
Torrust Improvement Experience
Quality & Assurance
Relates to QA, Testing, and CI
Testing
Checking Torrust
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul core Tracker: add tests for
databases
mod.Regarding the database drivers these are the methods in the Database trait grouped by context:
Schema:
Persistent torrents (stats):
Authentication keys (for private trackers):
Whitelist (for listed trackers):
Sub-tasks
driver
mod.rs
(no direct tests added)mysql.rs
sqlite.rs
error.rs
mod.rs
(no direct tests added)setup.rs
(no direct tests added)