Skip to content

Commit

Permalink
iio: imu: adis16400: release allocated memory on failure
Browse files Browse the repository at this point in the history
In adis_update_scan_mode, if allocation for adis->buffer fails,
previously allocated adis->xfer needs to be released.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Navidem authored and jic23 committed Oct 9, 2019
1 parent dcb1092 commit ab612b1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/iio/imu/adis_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ int adis_update_scan_mode(struct iio_dev *indio_dev,
return -ENOMEM;

adis->buffer = kcalloc(indio_dev->scan_bytes, 2, GFP_KERNEL);
if (!adis->buffer)
if (!adis->buffer) {
kfree(adis->xfer);
adis->xfer = NULL;
return -ENOMEM;
}

rx = adis->buffer;
tx = rx + scan_count;
Expand Down

0 comments on commit ab612b1

Please # to comment.