Close file before rotating in RollingFileLogWriter
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise a `java.nio.file.FileSystemException` will be raised, at least on Windows.
pm47
commented
Feb 24, 2025
| rollLogs() | ||
| true | ||
| } else false | ||
| private fun shouldRollLogs(logFilePath: Path): Boolean { |
There was a problem hiding this comment.
I changed the signature of this function because calling maybeRollLogs(fileSizeOrZero()) seemed cumbersome.
| @@ -136,8 +134,8 @@ open class RollingFileLogWriter( | |||
| private suspend fun writer() { | |||
| val logFilePath = pathForLogIndex(0) | |||
|
|
|||
| if (fileSystem.exists(logFilePath)) { | |||
| maybeRollLogs(fileSizeOrZero(logFilePath)) | |||
| if (fileSystem.exists(logFilePath) && shouldRollLogs(logFilePath)) { | |||
There was a problem hiding this comment.
AFAICT we should just do this:
Suggested change
| if (fileSystem.exists(logFilePath) && shouldRollLogs(logFilePath)) { | |
| if (shouldRollLogs(logFilePath)) { |
because metadataOrNull() already handled the case where the file doesn't exist.
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Feb 25, 2025
Waiting for touchlab/Kermit#433 to be merged.
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Feb 25, 2025
Waiting for touchlab/Kermit#433 to be merged.
pm47
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Feb 25, 2025
Initially the goal was to use Kermit's `RollingFileLogWriter`, but an issue was found during testing (see touchlab/Kermit#433) so we are using a local patched version in the meantime. Logging can be configured with these two new config parameters: - `--log-rotate-size` Log rotate size in MB (default 10 MB) - `--log-rotate-max-files`: Maximum number of log files kept (default 5)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise a
java.nio.file.FileSystemExceptionwill be raised, at least on Windows.