fix: Different hash for same dictionaries problem #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bj)`. The problem appears when the hash is calculated for two dictionaries like
`a = {'foo': 1, 'bar': 2}` and `b = {'bar': 2, 'foo': 1}.`
In this case, the calculated hashes obviously don't match, though from any other perspective, the dictionaries have no difference.
I suggest sorting keys in the dictionary alphabetically on the dict->str conversion.
I'm not a professional programmer so please check if my logic is valid and nothing is broken
alexeykomp
changed the title
alexeykomp
changed the title
toumorokoshi
approved these changes
Aug 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging unhashable types, the hash is calculated based on
str(obj).The problem appears when the hash is being calculated for two dictionaries like
{'foo': 1, 'bar': 2}and{'bar': 2, 'foo': 1}In this case, the calculated hashes don't match, though from any other perspective, the dictionaries have no difference.
I'd suggest sorting keys in the dictionary alphabetically on the dict->str conversion.
I'm not a professional programmer so please check whether my logic is valid and if nothing is broken.
make ready-prpassed.