use get_python_info for consistency and caching #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
blueyed
changed the title
obestwalter
approved these changes
Nov 19, 2019
|
Thanks! Seems like a no brainer to me :) |
blueyed
changed the title
|
ok, added a changelog. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've came across this when looking at the code - it obviously needs some cleanup, but passes all tests and got me a cache hit at least with a typical run. (IIRC it saves 0.2+s at least due to this).
Let me know if you like it and I/we can finish it.