-
-
Notifications
You must be signed in to change notification settings - Fork 533
Feat: free-threaded python support #3526
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: free-threaded python support #3526
Conversation
The approach looks good 😁 |
233dba0
to
f00b109
Compare
d804cfb
to
5a4298b
Compare
@gaborbernat that's interesting. The readthedocs build is failing because it's installing Now the question is how to best proceed. WDYT? Give the attribute a default value? Accept breaking the API? Something else entirely? |
This 😊 |
6d51f85
to
bcc9f37
Compare
7f6329f
to
04f2bd4
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
04f2bd4
to
4ccf8ad
Compare
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
I was about to pick this up again. Thanks for continuing. There was also another test I was about to adjust. Further, I wanted to discuss the fact that |
Yeah made it a dataclass. I'm fine breaking unpacking here.
Feel free to put in a new PR if there's anything else we can improve. Thanks! |
This PR adds support for experimental no-GIL CPython builds (aka. free-threaded).
It gives special semantics to factors like
py313t
which will then only select free-threaded Python 3.13.Note
This also means that factors like
py313
will no longer match free-threaded CPython builds.Related pypa/virtualenv#2809,
Closes: #3391
tox -e fix
)docs/changelog
folderPlease be aware that
py313
potentially also picking a free-threaded CPython build, that would break and they'd have to update their tox factor name topy313t
. I'm not sure there's a design that circumvents that.