-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ONNX avgpool1d #1744
ONNX avgpool1d #1744
Conversation
the failing test is because -
Idk what to do |
You can find a corresponding clippy warning and ignore it on that line or generate another random number by changing the seed in your python onnx script. This error is from clippy. It thinks you used a fraction of known constant. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 86.54% 86.61% +0.06%
==========================================
Files 699 700 +1
Lines 83223 83427 +204
==========================================
+ Hits 72025 72257 +232
+ Misses 11198 11170 -28 ☔ View full report in Codecov by Sentry. |
fixed. Pls review @antimora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Super minor fixes needed (removing accidentally checked in files and comment edit) . Please see inlined comments.
Once they're fixed, it's ready to be merged.
Thanks again for your contribution to the Burn project!
fixed @antimora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your contribution and improving Burn!
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
Avgpool 1d added to onnx import
Testing
Describe how these changes have been tested.