Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add onnx mean #2119

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Add onnx mean #2119

merged 8 commits into from
Aug 7, 2024

Conversation

cBournhonesque
Copy link
Contributor

@cBournhonesque cBournhonesque commented Aug 6, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

#1714

Changes

Add mean ops

Testing

Added test

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.23%. Comparing base (cd848b1) to head (ddd8051).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   86.21%   86.23%   +0.01%     
==========================================
  Files         690      691       +1     
  Lines       88620    88720     +100     
==========================================
+ Hits        76406    76506     +100     
  Misses      12214    12214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this operator! 🙏

Implementation looks good, just some very minor changes related to formatting before we can merge.

crates/burn-import/src/burn/node/base.rs Outdated Show resolved Hide resolved
crates/burn-import/src/burn/node/mean.rs Outdated Show resolved Hide resolved
@cBournhonesque
Copy link
Contributor Author

Thanks for contributing this operator! 🙏

Implementation looks good, just some very minor changes related to formatting before we can merge.

SG! Applied the fixes

@laggui laggui merged commit dad85e0 into tracel-ai:main Aug 7, 2024
14 checks passed
@cBournhonesque
Copy link
Contributor Author

@antimora you might want to update the original issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants