Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing output padding to conv transpose ONNX #2216

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Aug 29, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

https://discord.com/channels/1038839012602941528/1059209073784008835/1278708840145223764

Changes

Added output padding support for ONNX conv transpose.

Testing

Modified tests to include output padding.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (a88c69a) to head (5af8d47).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   85.74%   85.75%           
=======================================
  Files         707      707           
  Lines       89565    89585   +20     
=======================================
+ Hits        76801    76821   +20     
  Misses      12764    12764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laggui laggui merged commit a9abd8f into main Aug 29, 2024
10 checks passed
@laggui laggui deleted the fix/onnx/conv-transpose-2d branch August 29, 2024 18:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants