-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add onnx op trilu #2323
Add onnx op trilu #2323
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
+ Coverage 85.37% 85.38% +0.01%
==========================================
Files 768 770 +2
Lines 98673 98899 +226
==========================================
+ Hits 84238 84441 +203
- Misses 14435 14458 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this op 🙂
Implementation looks correct, just a minor comment regarding the tests.
Otherwise, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the changes! LGTM 🙂
Pull Request
Add ONNX Operator for Trilu in burn.
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1714
Changes
Add trilu onnx operators in burn-import
Modify related files
Testing