Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add onnx op trilu #2323

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Add onnx op trilu #2323

merged 9 commits into from
Oct 8, 2024

Conversation

tiruka
Copy link
Contributor

@tiruka tiruka commented Sep 30, 2024

Pull Request

Add ONNX Operator for Trilu in burn.

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1714

Changes

Add trilu onnx operators in burn-import
Modify related files

Testing

  • cargo test
  • ./run-checks.sh all

@tiruka tiruka marked this pull request as draft September 30, 2024 09:24
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 96.89441% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (e804f90) to head (f37f5a6).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-import/src/onnx/op_configuration.rs 71.42% 4 Missing ⚠️
crates/burn-import/src/burn/node/trilu.rs 99.01% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2323      +/-   ##
==========================================
+ Coverage   85.37%   85.38%   +0.01%     
==========================================
  Files         768      770       +2     
  Lines       98673    98899     +226     
==========================================
+ Hits        84238    84441     +203     
- Misses      14435    14458      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiruka tiruka marked this pull request as ready for review October 1, 2024 11:14
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this op 🙂

Implementation looks correct, just a minor comment regarding the tests.

Otherwise, great job!

crates/burn-import/onnx-tests/tests/test_onnx.rs Outdated Show resolved Hide resolved
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes! LGTM 🙂

@laggui laggui merged commit ebe2421 into tracel-ai:main Oct 8, 2024
11 checks passed
@tiruka tiruka deleted the add-onnx-op-trilu branch October 8, 2024 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants