Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build and export burn-hip only on linux target #2424

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Build and export burn-hip only on linux target #2424

merged 1 commit into from
Oct 25, 2024

Conversation

syl20bnr
Copy link
Member

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Prevent building burn-hip on other target family than linux.

Testing

Tested on Windows and Linux on both nvidia and amd GPUs

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (fe86c10) to head (ff96f59).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2424   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files         792      792           
  Lines      104455   104455           
=======================================
  Hits        89124    89124           
  Misses      15331    15331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit cb90cc1 into main Oct 25, 2024
11 checks passed
@laggui laggui deleted the hip-linux-only branch October 25, 2024 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants