Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ONNX op Random Uniform Like #2448

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

tiruka
Copy link
Contributor

@tiruka tiruka commented Nov 1, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

#1714
Blocked by #2441 (RandomNormalLike) because some portions are overlapped. -> DONE

Changes

This pull request introduces support for the RandomUniformLike operation in the burn-import crate. The most important changes include updating the supported ONNX operations, adding the necessary test files, and modifying the codebase to integrate the new operation.

Testing

run-checks all has passed and it succeeded in generating model with cargo r -- ./onnx-tests/tests/random_uniform_like/random_uniform_like.onnx ./out

@tiruka tiruka marked this pull request as draft November 1, 2024 03:09
@tiruka tiruka changed the title Add ONNX op Random Uniform Like WIP: Add ONNX op Random Uniform Like Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 99.03846% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@42f39f1). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-import/src/onnx/to_burn.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage        ?   84.85%           
=======================================
  Files           ?      794           
  Lines           ?   105295           
  Branches        ?        0           
=======================================
  Hits            ?    89345           
  Misses          ?    15950           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiruka tiruka marked this pull request as ready for review November 5, 2024 02:37
@tiruka tiruka changed the title WIP: Add ONNX op Random Uniform Like Add ONNX op Random Uniform Like Nov 5, 2024
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank for this follow up PR!

@laggui laggui merged commit 9b9b03c into tracel-ai:main Nov 7, 2024
11 checks passed
@tiruka tiruka deleted the add-onnx-op-random-uniform-like branch November 7, 2024 14:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants