chore: refactor testing to use mock HTTP responses #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirga
force-pushed
the
openai-testing
branch
11 times, most recently
from
dde81f7 to
c2c5981
Compare
nirga
force-pushed
the
openai-testing
branch
from
c2c5981 to
a90fdbf
Compare
nirga
force-pushed
the
openai-testing
branch
from
8499edb to
252caed
Compare
nirga
force-pushed
the
openai-testing
branch
from
e8739f5 to
df1e0f0
Compare
nirga
force-pushed
the
openai-testing
branch
from
57520a6 to
2292019
Compare
nirga
force-pushed
the
openai-testing
branch
from
b28cc74 to
e0576f5
Compare
galkleinman
approved these changes
Feb 13, 2024
| @@ -31,3 +32,9 @@ def joke_workflow(): | |||
| "joke_creation.task", | |||
| "pirate_joke_generator.workflow", | |||
| ] | |||
| open_ai_span = spans[0] | |||
There was a problem hiding this comment.
spans[0]? I would look for span by name.
Comment on lines
+36
to
+40
| assert ( | ||
| open_ai_span.attributes["llm.prompts.0.content"] | ||
| == "Tell me a joke about opentelemetry" | ||
| ) | ||
| assert open_ai_span.attributes.get("llm.completions.0.content") |
There was a problem hiding this comment.
the order seems off, doesn't it make more sense to assert the the value exists first?
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move tests for specific instrumentations to be under that instrumentation directory, and refactor to use VCR.py