SS4 Upgrade. #24
Merged
SS4 Upgrade. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bummzack I've merged up 3.1 into master and branched off 3, so that you can merge this into master (we'll alias as 4). can you rebase? |
|
@tractorcow Should be good to merge now. I've added the following branch alias: |
|
If you're deciding to add travis: I just saw that tests probably won't pass with the current |
Updated readme. Moved to TractorCow\OpenGraph namespace. Adhere/enforce SilverStripe coding conventions. Added a few unit-tests (not much, but better than nothing). Added .editorconfig, .upgrade.yml. Added phpunit, phpcs, scrutinizer and travis configs.
|
I've fixed the I also fixed the PR by removing the |
|
Oops sorry :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated readme.
Moved to TractorCow\OpenGraph namespace.
Adhere/enforce SilverStripe coding conventions.
Added a few unit-tests (not much, but better than nothing).
Added .editorconfig, .upgrade.yml.
Added phpunit, phpcs, scrutinizer and travis configs.