Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLL-314: add prototype pollution protection for merge helper function #1758

Conversation

SlicedSilver
Copy link
Contributor

Type of PR: bugfix

PR checklist:

  • Includes tests

Overview of change:
Prevents prototype pollution via the internal merge helper function in the unlikely case that user input or api responses are used directly for options and have been maliciously compromised.

@SlicedSilver SlicedSilver added the enhancement Feature requests, and general improvements. label Dec 17, 2024
@SlicedSilver SlicedSilver requested a review from edew December 17, 2024 18:06
@SlicedSilver SlicedSilver self-assigned this Dec 17, 2024
@SlicedSilver SlicedSilver changed the title Cll 314 add prototype pollution protection for merge helper function CLL-314: add prototype pollution protection for merge helper function Dec 17, 2024
tests/unittests/helpers.spec.ts Show resolved Hide resolved
@SlicedSilver SlicedSilver merged commit b419338 into master Jan 2, 2025
21 checks passed
@SlicedSilver SlicedSilver deleted the CLL-314_add_prototype_pollution_protection_for_merge_helper_function branch January 2, 2025 14:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Feature requests, and general improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants