-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updating dependencies to work with node 14 and for the tests to pass #9
Draft
martinheidegger
wants to merge
33
commits into
master
Choose a base branch
from
update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinheidegger
commented
Jan 12, 2022
- node_modules/scrypt can not be compiled with Node 14
- ethereumjs-testrpc is deprecated in favor of ganache
- forever is not node 14 compatible (used when testing the engine)
- Several tests fail with timeout -> Increased timeout
- Ethereum test hangs at fdd5cb365db5571a6ef6ea098f329b8b3d8bab0a during the e2e tests:
- "watch txId"
- "sender seals"
- "receiver seals"
- "delete watch after X confirmed"
- "object publish status"
- "versioning can only be done by previous author"
- "send sealed"
- Ethereum test error at x during sealwatch tests:
- "watch":
- "batch": batch timed out after 100000ms
- "watch":
- Missing dependency updates:
- "bl" as dependency of old levelup
- "elliptic" as deep depdenency of web3
- "underscore" as deep dependency of web3
- "socket.io-parser" as deep dependency of sendy
- "lodash" as deep dependency of ganche-core
- "node-fetch" as deep dependency of web3
…0% node14 compatible
require statements can be defined using circular dependencies, typescript types and humans have problems with this. this commit makes sure we use a normal dependency tree without back references.
By compiling the schema ahead of time (as recommended in the documentation of protocol-buffers) the startup time should be reduced and the performance enhanced at the same time.
This will make execution faster as the assert operation doesn’t try to jit compile. Furthermore all checks are typed now.
…ng anything The more changes come to the code the more of a problem the obsolete code becomes as it is impossible to say if it could ever be reinstated to working code.
…r on that - also, it is better to move to ts/esm at a later point
…ady available constants
by using the dynamic syntax, code completion doesn't work as well and it is more difficult to turn into typescript code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.