Remove Forwardable and release 0.2.5 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotonick
reviewed
May 15, 2023
lib/reform/form/active_model.rb
Outdated
| def_delegators :model, :persisted?, :to_key, :to_param, :id | ||
| %i(persisted? to_key to_param id).each do |method| | ||
| define_method method do | ||
| model.public_send(method) |
There was a problem hiding this comment.
Can we not simply use https://www.rubydoc.info/gems/activesupport/Module:delegate as you suggested in the first place?
There was a problem hiding this comment.
You're right, I updated the code to use rails' delegate method instead.
Extending Ruby's Forwardable module adds a `delegate` method to each form which overrides the often used `delegate` method of Rails. To prevent this we just use the `delegate` method of Rails instead. Fixes #99
richardboehme
force-pushed
the
boehme/remove-forwardable
branch
from
f28b24b to
271574c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99