Move finalization out of the transition lock

tramlinehq · Oct 31, 2024 · 5eb8bde · 5eb8bde
1 parent 388527a
commit 5eb8bde
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/models/step_run.rb b/app/models/step_run.rb
@@ -156,9 +156,7 @@ class StepRun < ApplicationRecord
       transitions from: [:deployment_started, :deployment_restarted], to: :failed_with_action_required
     end
 
-    event(:finish) do
-      after { event_stamp!(reason: :finished, kind: :success, data: stamp_data) }
-      after { finalize_release }
+    event(:finish, after_commit: :finalize_release) do
       transitions from: [:deployment_started, :deployment_restarted], to: :success
     end
 
@@ -515,6 +513,7 @@ def after_finish_ci
   end
 
   def finalize_release
+    event_stamp!(reason: :finished, kind: :success, data: stamp_data)
     Coordinators::FinishPlatformRun.call(release_platform_run) if release_platform_run.finalizable?
   end
 end