Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAIN B-22769 #14874

Merged
merged 4 commits into from
Feb 28, 2025
Merged

MAIN B-22769 #14874

merged 4 commits into from
Feb 28, 2025

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Feb 22, 2025

INT PR

Agility ticket

Summary

There was a prod defect that was occurring with PPMs during closeout when the PPM weight was less than 500 pounds and in the same ZIP. There was some logic thrown in a while back that was changing the # service item to be shorthaul instead of linehaul and the isPPM check was not implemented in the shorthaul pricer - this was the cause of the error because we don't allow shipments of less than 500 pounds when # shorthaul for other shipment types.

This PR does the following:

  • adds isPPM to the shorthaul pricer and considers it when checking the weight
  • updates some iterator logic to use a loop instead of the less stable serviceItemsToPrice[0]
  • adds a test to the shorthaul pricer
  • update mocks

How to test

  1. Fire up MilMove as a customer
  2. Set up a PPM
  3. Approve as SC
  4. Go back as customer and start the closeout process
  5. Set up allllll of your closeout addresses to be the same ZIPs
  6. Fill out your weight ticket and make the weight marginal, less than 500 pounds
  7. Confirm you can proceed without error

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Feb 22, 2025
@danieljordan-caci danieljordan-caci self-assigned this Feb 22, 2025
@danieljordan-caci danieljordan-caci marked this pull request as ready for review February 28, 2025 14:29
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner February 28, 2025 14:29
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash matches

@deandreJones deandreJones merged commit df502ed into main Feb 28, 2025
11 of 14 checks passed
@deandreJones deandreJones deleted the MAIN-B-22769 branch February 28, 2025 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

3 participants