MAIN B-22653 #14889
Merged
MAIN B-22653 #14889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting value on shipment creation
danieljordan-caci
added
Mountain Movers
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Draft
danieljordan-caci
requested review from
a team,
deandreJones,
TevinAdams,
cameroncaci and
traskowskycaci
traskowskycaci
approved these changes
Feb 28, 2025
TevinAdams
approved these changes
Feb 28, 2025
deandreJones
approved these changes
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
Agility ticket
Feature Flag PR
Summary
This is the db & feature flag prep work for the upcoming work for PPM-SPR (Small Package Reimbursement). Since this will be a
NOT NULLvalue and the Go structs were updated, I went ahead and added some backend code to update thePPMTypetoINCENTIVE_BASEDuntil we implement additional backend code that will update based on what we consume from the UI.This PR has three migrations that do the following:
ppm_typetoppm_shipmentsppm_shipment_typeenum to theppm_shipment.ppm_shipment_typecolumnSMALL_PACKAGEto the existingmoving_expense_typeHow to test
serverand ensure the migrations run and swagger code generatesppm_shipmentsshould now have appm_typecolumn that is an enum ofppm_shipment_typeSMALL_PACKAGEtype added to themoving_expense_typeenumINCENTIVE_BASEDis populated for each newly created PPMScreenshots