Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

B 22294 INT Part 1 - Migrate queue function to ddl_functions #14903

Open
wants to merge 11 commits into
base: integrationTesting
Choose a base branch
from

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Feb 26, 2025

B-22294 Agility Ticket

Summary

Per Ricky's suggestion I'm moving this existing function to the ddl_functions folder in a separate PR so that the changes for this task will be more obvious in the primary PR.

There's also some minor unrelated changes that pre-commit insisted on.

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Does the get_destination_queue function look look/work the same as it did in the original PR?
    2.go test ./pkg/services/order -testify.m TestListDestinationRequestsOrders

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

@ajlusk ajlusk added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 26, 2025
@ajlusk ajlusk self-assigned this Feb 26, 2025
@ajlusk ajlusk marked this pull request as ready for review February 26, 2025 17:32
@ajlusk ajlusk requested a review from a team as a code owner February 26, 2025 17:32
@ajlusk ajlusk requested review from a team and removed request for MInthavongsay, antgmann, r-mettler and CoryKleinjanCACI February 26, 2025 18:07
@r-mettler
Copy link
Contributor

go test ./pkg/services/order -testify.m TestListDestinationRequestsOrders passed
Looks and functions like original.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

2 participants