B 22294 INT Part 2 - Add secondary sort column to queues (Review after Part 1)

[ajlusk]

B-22294 Agility Ticket

Summary

Updates the queues to all have a secondary sort column, the move code (chosen by a PO). Previously when a queue was sorted by a column containing non-unique values (like branch or status) there was inconsistent ordering within each of the non-unique primary sort values. This was most noticeable when switching page sizes or exporting the queue to CSV (because that re-requests the queue with a page size equal to the total moves in the queue).

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

How to test

You may need to use the test harness data generator to have enough moves to fill your queues

1. Access the office app as a SC with a queue greater than 10 moves (devseed KKFA should do)
2. Sort by a column with non-unique values like status
3. Change the page size. Does the order within statuses stay the same?
4. Repeat with other columns.
5. Switch to a page size less than the total number of moves in your queue, export to CSV, does the order match?
6. Repeat with the Closeout Queue
7. Repeat as a TIO with the Payment Requests Queue.
8. Repeat as a TOO with the Move Queue.
9. Repeat as a TOO with the Destination Requests Queue.

For the destination requests queue the following test harness scenario may be helpful:

• IntlHHGMoveDestSITExtensionRequestedAKZone1AirForce
• IntlHHGMoveDestSITExtensionRequestedAKZone1Army
• IntlHHGMoveDestSITExtensionRequestedAKZone1SpaceForce
• IntlHHGMoveDestAddressRequestedAKZone1AirForce
• IntlHHGMoveDestAddressRequestedAKZone1Army
• IntlHHGMoveDestAddressRequestedAKZone1SpaceForce

All of the above will add moves to that queue under the MBFL GBLOC.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots