B 22796 int #14917
B 22796 int #14917
Conversation
disable bookmark extraction in tests
B-21322 TPPS ECS Scheduled Task - MAIN
loganwc
requested review from
paulstonebraker,
joeydoyecaci,
pambecker and
JonSpight
There was a problem hiding this comment.
Testing instructions work as written. I compared this to INT and this PR definitely solves the "Oops, Something went wrong" problem.
However, the page that now loads gives a different error on submission when following the testing steps. The customer never submitted a current or backup address and when the SC goes to fill that for them customer_updater.go is expecting those address to already exist (since it's an updater) and throws a nil pointer error.
The above issue may not be in scope but I couldn't find it documented.
The two changes to primeapiv2 should probably be removed to not re-introduce the conflict.
| services.VLocation | ||
| planner route.Planner |
There was a problem hiding this comment.
Other changes are matching main and int up so there aren't merge conflicts anymore.
I've been seeing the same conflict but it looks like someone else beat you to fixing this conflict. Both integrationTesting and main have vLocation last now.
There was a problem hiding this comment.
recently updated with int and it's still showing them for some reason 🤔
There was a problem hiding this comment.
I think accepting the version from your main branch into your INT branch (before the two matched) made 2c10ce7 the latest version.
Agility ticket
Summary
There was an error when SC tries to make a move for a brand new user without their backup contact info saved.
Note
Other changes are matching main and int up so there aren't merge conflicts anymore.
How to test