downgrade maven-source-plugin to make release build pass #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiana528
commented
Jul 10, 2024
pom.xml
Outdated
| @@ -332,7 +332,7 @@ | |||
| <execution> | |||
| <id>attach-sources</id> | |||
| <goals> | |||
| <goal>jar</goal> | |||
| <goal>jar-no-fork</goal> | |||
There was a problem hiding this comment.
Without this change, the mvn command for release fail.
mvn deploy -DperformRelease=true
[INFO] --- maven-source-plugin:3.3.0:jar (attach-sources) @ td-client ---
[INFO] Building jar: /Users/wang.yan/work/td-client-java/target/td-client-1.1.1-sources.jar
[INFO]
[INFO] --- maven-source-plugin:3.3.0:jar-no-fork (attach-sources) @ td-client ---
[ERROR] We have duplicated artifacts attached.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.185 s
[INFO] Finished at: 2024-07-10T09:13:58+09:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources) on project td-client: Presumably you have configured maven-source-plugn to execute twice times in your build. You have to configure a classifier for at least on of them. -> [Help 1]
There was a problem hiding this comment.
tiana528
changed the title
yuokada
approved these changes
Jul 10, 2024
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.