This repository was archived by the owner on Feb 6, 2019. It is now read-only.
Grammar builder ergonomics — throw if incorrect signature used #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
reviewed
Aug 6, 2018
| error = e; | ||
| } | ||
| assert.propertyVal(error, 'message', | ||
| `repeat takes a single argument, but 0 were given. Did you mean to use blank()?`) |
There was a problem hiding this comment.
I think we probably shouldn't suggest blank here, since repeat(blank()) wouldn't be useful. Maybe just the initial sentence in that case?
| @@ -67,15 +67,15 @@ prec.right = function(number, rule) { | |||
| }; | |||
| } | |||
|
|
|||
| prec.dynamic = function(number, rule) { | |||
| prec.dynamic = maxArgs(function(number, rule) { | |||
There was a problem hiding this comment.
Should we wrap prec, prec.left, and prec.right in maxArgs too?
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, throw if grammar builder functions are passed wrong number of args. This catches the common (for me) problem of doing something like
optional('+', $.term)when I meant to dooptional(seq('+', term)).