Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Settings not being saved when program closes due to DS3 exiting #9

Closed
tremwil opened this issue Aug 3, 2021 · 0 comments
Closed

Settings not being saved when program closes due to DS3 exiting #9

tremwil opened this issue Aug 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@tremwil
Copy link
Owner

tremwil commented Aug 3, 2021

When DarkSouls_HasExited is called upon the game process shutting down, the code attempts to call the window Close() function directly. However, this generates an exception since the event is triggered in another thread. Hence the program crashes before settings can be saved. To be fixed in V4.2.

@tremwil tremwil added the bug Something isn't working label Aug 3, 2021
@tremwil tremwil closed this as completed Aug 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant