Support for ssl key/cert as base64 string #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
force-pushed
the
base64_ssl_certs
branch
from
49f04ef to
6b6982d
Compare
arbulu89
approved these changes
Jan 23, 2024
| @@ -276,6 +276,8 @@ These variables are the defaults of our roles, if you want to override the prope | |||
| | web_admin_username | Username of the admin user in web application | admin | | |||
| | enable_alerting | Enable the alerting mechanism on web project | false | | |||
| | install_nginx | Install nginx | true | | |||
| | nginx_ssl_cert_as_base64 | Nginx ssl certificate provided as base64 string | false | | |||
There was a problem hiding this comment.
I guess nginx_ssl_cert and nginx_ssl_key are not documented 😞
There was a problem hiding this comment.
I will document them in the other pr #21
arbulu89
approved these changes
Jan 23, 2024
Vagrantfile
Outdated
| prometheus_url: "http://localhost", | ||
| web_admin_password: "adminpassword", | ||
| trento_server_name: "trento.local trento.local:8080" | ||
| trento_server_name: "trento.local trento.local:8080", | ||
| nginx_ssl_cert_as_base64: "false", |
There was a problem hiding this comment.
Do you need to put them with the default value?
There was a problem hiding this comment.
No, it was a reminder for me, but we can remove them
CDimonaco
force-pushed
the
base64_ssl_certs
branch
from
35675ef to
8a4a53d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggest, this pr adds support for ssl key/certs as base64.
This is useful when we need to pass multiple line ssl certificates through cli, encoding as base64 ensure single line and preserve multiline content