Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Update gin gonic to the latest version due to major breaking bug in the router mechanism #610

Conversation

fabriziosestito
Copy link
Member

The route /checks/catalog was overriding the route of /checks/:id/catalog when :id was staring with the letter c.

Updating to the latest gin gonic version solves the problem.

More info: gin-gonic/gin#2696

Solves: #608 and partially #606

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabriziosestito fabriziosestito merged commit 2343870 into trento-project:main Dec 20, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Development

Successfully merging this pull request may close these issues.

5 participants