Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core): ensure proper handling of vendor string #4239

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Oct 2, 2024

This PR fixes a bug introduced in #4188 that caused an invalid read of the vendor string from the vendor header.

Before the fix, trezorctl get-features printed:

...

fw_vendor: 'UNSAFE, DO NOT USE!TOIfx',

...

No changelog entry is needed since this bug wasn't released yet.

@cepetr cepetr added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4) T2T1 Trezor Model T T3T1 Trezor Safe 5 T3B1 Trezor Safe 3 (U5) labels Oct 2, 2024
@cepetr cepetr requested a review from TychoVrahe October 2, 2024 11:15
@cepetr cepetr self-assigned this Oct 2, 2024
@cepetr cepetr requested a review from prusnak as a code owner October 2, 2024 11:15
@cepetr cepetr merged commit f54edd0 into main Oct 2, 2024
375 checks passed
@cepetr cepetr deleted the cepetr/vendor-name-fix branch October 2, 2024 14:57
@bosomt
Copy link

bosomt commented Oct 10, 2024

QA OK

trezorctl get-features
Features (212 bytes) {
    bootloader_locked: True,
    busy: False,
    device_id: '36214063F33A7BA5825E8DEC',
    fw_vendor: 'DEV ONLY, DO NOT USE!',
    haptic_feedback: True,
    homescreen_format: Jpeg (2),
    homescreen_height: 240,
    homescreen_width: 240,
    initialized: True,
    internal_model: 'T3T1',
    label: '284 acad',
    language: 'en-US',
    language_version_matches: True,
    major_version: 2,
    minor_version: 8,
    model: 'Safe 5',
    optiga_sec: 0,
    patch_version: 4,
    pin_protection: True,
    revision: 20 bytes 0xd71d9e9c343ad04a7f28d6b02f8d3f8945af30d6,

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4) T2T1 Trezor Model T T3B1 Trezor Safe 3 (U5) T3T1 Trezor Safe 5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants