fix drawing of 1pix bar shape #4704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cepetr
force-pushed
the
cepetr/fix-bar-shape
branch
from
e529bd4 to
1972712
Compare
TychoVrahe
approved these changes
Mar 3, 2025
TychoVrahe
approved these changes
Mar 3, 2025
[no changelog]
[no changelog]
cepetr
force-pushed
the
cepetr/fix-bar-shape
branch
from
608c89f to
54fe592
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #4702 and fixes the prodtest build for T3W1 rev A.
If the background and foreground colors are the same, the bar thickness is not considered. This fixes the problem with 1-pixel bars and also optimizes drawing, as suggested in #4702.