Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update SWIG modules to be compatible with the current SWIG #220

Closed
wants to merge 17 commits into from

Conversation

sethrj
Copy link
Collaborator

@sethrj sethrj commented Feb 27, 2018

The most significant change was that it's no longer possible for %fragment to inject code when it's imported. This required a workaround for the exception handling code, and it also prevents the Tpetra types from propagating into downstream modules.

@sethrj sethrj requested a review from aprokop February 27, 2018 19:55
@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@f25352a). Click here to learn what that means.
The diff coverage is 57.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #220   +/-   ##
==========================================
  Coverage           ?   39.84%           
==========================================
  Files              ?       33           
  Lines              ?    12811           
  Branches           ?        0           
==========================================
  Hits               ?     5104           
  Misses             ?     7707           
  Partials           ?        0
Impacted Files Coverage Δ
src/simple/src/fortrilinos.f90 60.74% <ø> (ø)
src/utils/src/forerror.f90 0% <ø> (ø)
src/tpetra/src/fortpetraFORTRAN_wrap.cxx 24.31% <ø> (ø)
src/belos/src/forbelosFORTRAN_wrap.cxx 0% <0%> (ø)
src/simple/src/fortrilinosFORTRAN_wrap.cxx 31.47% <0%> (ø)
src/utils/src/fortest.f90 43.54% <0%> (ø)
src/belos/src/forbelos.f90 0% <0%> (ø)
src/simple/test/test_simple_solver_handle.f90 95% <100%> (ø)
src/tpetra/test/test_tpetra_import_export.f90 100% <100%> (ø)
src/tpetra/test/test_tpetra_crsgraph.f90 95% <100%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25352a...dbe3125. Read the comment docs.

@sethrj
Copy link
Collaborator Author

sethrj commented Mar 8, 2018

I've removed the warnings from the fortpetra and forteuchos modules. This PR also fixes #177 .

This was referenced Mar 8, 2018
@aprokop
Copy link
Collaborator

aprokop commented Mar 21, 2018

Superseded by #221.

@aprokop aprokop closed this Mar 21, 2018
@sethrj sethrj deleted the latest-swig branch March 21, 2018 17:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants