Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleaning up RCP-related memory errors #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleaning up RCP-related memory errors #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified scripts/docker_flang70_env.sh
100644 → 100755
View file
Open in desktop
Empty file.
5 changes: 2 additions & 3 deletions src/interface/test/Tpetra_ModelEvaluator_1DFEM.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,12 +585,11 @@ subroutine delete_TpetraModelEvaluator1DFEM(self)
call self%node_coords%release()
call self%x%release()
call self%J_diagonal%release()
call solnvec%release()
deallocate(solnvec)

#ifdef __GNUC__
! FIXME This segfaults with Flang
! Call base class release()
call self%ForModelEvaluator%release()
#endif
end subroutine

end module TpetraModelEvaluator1DFEM_module
1 change: 1 addition & 0 deletions src/interface/test/test_futility_reproducer.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ program main
call plist%release(); FORTRILINOS_CHECK_IERR()
call X%release(); FORTRILINOS_CHECK_IERR()
call A%release(); FORTRILINOS_CHECK_IERR()
call B%release(); FORTRILINOS_CHECK_IERR()
call map%release(); FORTRILINOS_CHECK_IERR()
call comm%release(); FORTRILINOS_CHECK_IERR()
deallocate(eindex)
Expand Down
7 changes: 3 additions & 4 deletions src/interface/test/test_nox.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ subroutine main2(comm, params, ierr)
use fortrilinos
use TpetraModelEvaluator1DFEM_module
implicit none
integer :: ierr
type(TeuchosComm) :: comm
type(ParameterList) :: params
integer, intent(out) :: ierr
type(TeuchosComm), intent(in) :: comm
type(ParameterList), intent(in) :: params
class(ForModelEvaluator), allocatable :: evaluator
type(NOXSolver) :: nox_solver
integer(global_size_type) :: num_global_elems
Expand Down Expand Up @@ -87,7 +87,6 @@ subroutine main2(comm, params, ierr)
call evaluator%release(); FORTRILINOS_CHECK_IERR()
deallocate(evaluator)

call params%release(); FORTRILINOS_CHECK_IERR()
call nox_solver%release(); FORTRILINOS_CHECK_IERR()

end subroutine main2
Expand Down
6 changes: 2 additions & 4 deletions src/interface/test/test_solver_handle.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,10 @@ subroutine delete_TriDiagOperator(self)
call self%domain_map%release()
call self%range_map%release()

#ifdef __GNUC__
! FIXME This segfaults with Flang
! Call base class release()
call self%ForTpetraOperator%release()
#endif
end subroutine

end subroutine

end module

Expand Down Expand Up @@ -371,6 +368,7 @@ program main
call solver_handle%release(); FORTRILINOS_CHECK_IERR()
call plist%release(); FORTRILINOS_CHECK_IERR()
call X%release(); FORTRILINOS_CHECK_IERR()
call residual%release(); FORTRILINOS_CHECK_IERR()
call B%release(); FORTRILINOS_CHECK_IERR()
call A%release(); FORTRILINOS_CHECK_IERR()
call map%release(); FORTRILINOS_CHECK_IERR()
Expand Down