Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose query starting time #23113

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Expose query starting time #23113

merged 2 commits into from
Aug 26, 2024

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Aug 23, 2024

Query starting time contains
SplitSourceFactory#createSplitSources
which could be expensive for some connectors.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Event listener
* Expose query starting time in `QueryStatistics`. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 23, 2024
@sopel39 sopel39 force-pushed the ks/starting_metric branch 3 times, most recently from 36d1a33 to 3835323 Compare August 23, 2024 11:29
Reported query start time is computed after call to
SplitSourceFactory#createSplitSources, and that method
may take a lot of time for some connectors.
@sopel39 sopel39 force-pushed the ks/starting_metric branch from 3835323 to 64e75bd Compare August 26, 2024 12:44
@sopel39 sopel39 merged commit aea9079 into trinodb:master Aug 26, 2024
2 of 12 checks passed
@sopel39 sopel39 deleted the ks/starting_metric branch August 26, 2024 12:45
@github-actions github-actions bot added this to the 455 milestone Aug 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

2 participants