List delete files in Iceberg's $files metadata table #23142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
requested review from
ebyhr,
findinpath,
0xffmeta,
pajaks,
wendigo and
alexjo2144
nineinchnick
force-pushed
the
fix_files_system_table
branch
from
3f19cc4 to
9e1f508
Compare
wendigo
approved these changes
Aug 27, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/FilesTable.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Aug 27, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/FilesTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergSystemTables.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
fix_files_system_table
branch
from
9e1f508 to
9a7fafe
Compare
wendigo
approved these changes
Aug 28, 2024
pajaks
reviewed
Aug 28, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergSystemTables.java
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #16232 with review comments applied - avoid reflection and use column position to read data. I preserved the commit author.
Fixes #16233
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: